Chore: bump to v4.33.0 - #1747
Open
ajirving wants to merge 6 commits into
Open
Conversation
Follow-up fixes for the toolchain bump: - `Set.mem_setOf_eq` -> `Set.mem_ofPred_eq`, `Set.setOf_and` -> `Set.ofPred_and` - `infinite_setOf_prime*` -> `infinite_setOfPred_prime*` - `ENat.map_coe` -> `ENat.map_natCast` - `Finset.min'` now takes a `Finset.Nonempty`, not a bare existential - `integrableOn_rpow_mul_exp_neg_mul_rpow` now wants `0 < 1` rather than `1 <= 1` - `PNat` subtype anonymous constructors replaced by `Nat.succPNat` / `Nat.toPNat` - Replace `haveI`/`letI` with `have`/`let` where the instance binder is no longer needed - Rework a few `simp`/`aesop` proofs (rough_set primes, table_8 bounds) that no longer close under the new simp set Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly trivial fixes, lots of deprecation changes because of the change from setOf to ofPred, a few minor proof changes. Note there are a number of deprecation warnings coming from LeanCert because it's still using the setOf functions.