feat(IK): prove isCompletelyMultiplicative_liouville - #1746
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1685.
Motivation
isCompletelyMultiplicative_liouvillewas the lastsorrystanding between theliouvilledefinition andLSeries_liouville_eq(IK'sidentity), which needs complete multiplicativity to run the Euler product.
Scope
isCompletelyMultiplicative_liouvilleinIwaniecKowalskiCh1.lean.sorryintroduced.The proof is the paper's own reason:$\Omega$ is completely additive, so
$\lambda = (-1)^{\Omega}$ is completely multiplicative over
ℤ, and theℝ-valued statement is that identity pushed throughInt.cast. Concretely itthreads through Mathlib's
cardFactors_mulrather than inventing machinery —IsCompletelyMultiplicativequantifies over alla b : ℕincluding0, sothe two zero cases are discharged first (arithmetic functions vanish at
0),and
cardFactors_multhen covers the rest.Note for reviewers: this duplicates Mathlib
While proving this I found that Mathlib already carries the same function and
the same fact, in
Mathlib/NumberTheory/ArithmeticFunction/Liouville.lean:liouville_apply_mulis exactly the multiplicative half of this PR's goal, forall
m nincluding zero. The localliouvillehere istoArithmeticFunction (fun n => (-1 : ℤ) ^ Ω n), which unfolds to the samefunction.
I did not switch to it in this PR, because
Mathlib.NumberTheory.LSeries.Dirichletdoes not appear to pull that file in, so using it means adding an import — a
scope change I'd rather not smuggle into a
sorry-closing PR (§1). If you'dprefer the local
liouvillebe replaced by (or proved equal to) Mathlib's, I'mhappy to do that as a follow-up; it would also give
LSeries_liouville_eqashorter route. Flagging per §14.
Test plan
lake build PrimeNumberTheoremAnd.IwaniecKowalskiCh1— clean.declaration uses 'sorry'. The file'ssorrycount goes 7 → 6; the warning at line 1789 is gone and no new one appears.
lake build :blueprint— not run. I started it and had to kill it:this machine has ~1.3 GB free after the Mathlib cache, and the full-project
build was consuming it fast enough to run out. This diff changes only a
proof body — no
@[blueprint]title/statement/prooffield and noreferences.bibentry — so the generated per-module.texshould bebyte-identical, but I have not verified that and am not claiming I did.
Please let CI cover it, or tell me and I'll free space and re-run.