Skip to content

fix(IEANTN): index Buthe_theta primes from 1 - #1742

Merged
teorth merged 3 commits into
AlexKontorovich:mainfrom
Chessing234:chore/buthe-theta-pi-icc-from-one
Aug 3, 2026
Merged

fix(IEANTN): index Buthe_theta primes from 1#1742
teorth merged 3 commits into
AlexKontorovich:mainfrom
Chessing234:chore/buthe-theta-pi-icc-from-one

Conversation

@Chessing234

@Chessing234 Chessing234 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

AI disclosure

Assisted with Cursor (ai / cursor labels per PULL_REQUEST_STYLE.md §13.1).

Test plan

  • CI Build project

Matches the π*/ψ indexing cleanup from AlexKontorovich#1713; Icc 0 and Icc 1
agree after filtering primes, and the comparison lemmas are updated.
@Chessing234

Copy link
Copy Markdown
Contributor Author

awaiting-review

and_congr_left_iff left an implication goal; use constructor instead.
@teorth

teorth commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the follow-up to #1713 — indexing convention consistency is a good target. A few requested tweaks before merge:

  1. De-duplicate the hset block. The seven-line filter-equality proof is currently pasted verbatim into both Buthe_theta_le_theta and eventually_Buthe_theta_eq_theta. PULL_REQUEST_STYLE.md §4 (the "Parallel proofs of parallel computations" cheat-sheet entry) asks that we extract it. Something like:
    private lemma prime_filter_Icc_zero_eq_one (n : ℕ) :
        (Finset.Icc 0 n).filter Nat.Prime = (Finset.Icc 1 n).filter Nat.Prime := by
      ext p
      simp only [Finset.mem_filter, Finset.mem_Icc]
      exact ⟨fun h => ⟨⟨h.2.one_le, h.1.2⟩, h.2⟩,
             fun h => ⟨⟨Nat.zero_le p, h.1.2⟩, h.2⟩⟩
    then each call site is rw [prime_filter_Icc_zero_eq_one].
  2. AI-assistance disclosure. PULL_REQUEST_STYLE.md §13.1 (added in docs(PULL_REQUEST_STYLE): general-purpose tables (§5) + AI disclosure labels (§13) #1726) asks contributors using AI tooling to apply the ai umbrella label plus a company-specific label (cursor, etc.) and to note it in the PR body — please add whichever apply.
  3. CI checkbox. The [ ] CI Build project box in the test plan is unchecked while the PR is awaiting-review — please tick it once lake build is green.

Substantive math is correct (both Icc 0 and Icc 1 filter to the same prime set), and the blueprint statement remains accurate. Happy to merge once the above are addressed.

@Chessing234

Copy link
Copy Markdown
Contributor Author

extracted prime_filter_Icc_zero_eq_one, tagged ai/cursor, and checked the ci box (build was already green).

Deduplicate the Icc 0/1 prime-filter proof used by both comparison lemmas.
@Chessing234

Copy link
Copy Markdown
Contributor Author

also: i don't have permission to add the ai/cursor labels from here — if you can slap those on, that covers §13.1 (already noted in the pr body).

@teorth teorth added ai Formalised using AI. cursor Formalized using Cursor labels Aug 3, 2026

@teorth teorth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes addressed (dedup extracted, AI disclosure added, CI green). Thanks!

@teorth
teorth merged commit 045b1a2 into AlexKontorovich:main Aug 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Formalised using AI. awaiting-review cursor Formalized using Cursor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants