refactor: Make linter stricter#233
Open
martinreinhardt01 wants to merge 2 commits intomainfrom
Open
Conversation
Add extend-select = [B] in pyproject.toml. Across src, tests, and utils, make zip() calls explicit with strict=False, set stacklevel on deprecation warnings, chain re-raised errors with from, and silence B027 on BaseLLM.__del__. Replace misleading multi-character strip() on fenced SQL completions with removeprefix/removesuffix; minor vllm loop/getattr cleanup; wrap a few long lines (e.g. plot-results, formatter hash assertion).
Add ARG to extend-select. Keep public-facing signatures stable by restoring original parameter names and suppressing ARG001/ARG002/ARG005 via inline on affected definitions; includes small follow-up fixes to avoid undefined names introduced by the revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
/docs/).What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the hardware and config this has been tested on, as well as any relevant
additional information.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?