Skip to content

Update fedora build dependencies for david#293

Merged
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
tapple:patch-1
Jun 3, 2026
Merged

Update fedora build dependencies for david#293
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
tapple:patch-1

Conversation

@tapple
Copy link
Copy Markdown
Contributor

@tapple tapple commented Jun 3, 2026

the new david dependency needs nasm

the new david dependency needs nasm
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 01c57304-8afd-476e-9ba9-bad0420107b5

📥 Commits

Reviewing files that changed from the base of the PR and between 449c281 and 149304f.

📒 Files selected for processing (1)
  • doc/BUILD.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated Fedora/RHEL build setup instructions (Fedora 44+) to include required system packages for proper project compilation.

Walkthrough

The pull request updates doc/BUILD.md to add the nasm assembler package to the Fedora 44+ Linux system dependency list. The existing package list is reformatted across two lines while adding the new required dependency.

Changes

Fedora Build Dependencies

Layer / File(s) Summary
Add nasm to Fedora 44+ dependencies
doc/BUILD.md
The Fedora 44+ system package requirement list is updated to include nasm and reformatted across two lines in the build setup documentation.

🎯 1 (Trivial) | ⏱️ ~2 minutes

A bunny hops through the docs with glee, 🐰
Adding nasm to Fedora's spree,
Build dependencies are neat and clean,
The finest packages ever seen! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal (5 words) and missing most required template sections including detailed description, related issues link, and completion checklist. Expand the description to follow the template: provide context on the david dependency change, link any related issues, complete the checklist, and verify testing was done.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to updating Fedora build dependencies and mentions 'david', which aligns with the PR's actual change: adding the nasm package to Fedora/RHEL dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RyeMutt RyeMutt merged commit 1f9b66e into AlchemyViewer:develop Jun 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants