Custom status script

[charlie-in-spain]

Hi!

First of all, I've realized that maybe modding issues don't fit here and they should rather go in "Discussions". Please let me know so that I place these topics correctly.

I'm trying a custom status following the wiki: https://github.com/Albeoris/Memoria/wiki/Modding-status-effects
I'm designing a C# script that is very similar to PoisonStatusScript since it also handles the parameters "Target.CurrentHp" and "Target.MaximumHP", but it doesn't seem to work in battle.
Therefore, I've tried to redo "PoisonStatusScript.cs" as a custom script and call it from an external battle script, in order to check if I'm doing it fine. So I've followed these steps:

-I've registered it in CommonScript.cs as:
public const BattleStatusId Test = BattleStatusId.CustomStatus1;

-I've donde a copy of "PoisonStatusScript.cs" as "TestStatusScript.cs", and in its content I changed the attribute and sub-class at the beginning:
[StatusScript(CommonScript.Test)]
public class TestStatusScript : StatusScriptBase, IOprStatusScript
The rest of the content is the same as in "PoisonStatusScript.cs".

-I've added an entry in "StatusData.csv" (editing with Notepad) with a new ID for "Test" status, and the same values as Poison status from the original game. This seems to be recognised because I've tried to add a color for test in "ColorKind" parameter and it is showing in battle.

Then in battle the poison icon appears above character's head when inflicted with "Test" status, but nothing happens: no damage is inflicted nor shown on the character. Maybe there's something else to do in order to make it work as in the original Poison status script?
My idea is that if I manage to make this "copy" work, I should be able to do the same with my custom script.

I'm calling this "Test" status from an external battle script with:
_v.Target.TryAlterSingleStatus(CommonScript.Test, true, _v.Caster);

Regards!

[Tirlititi]

Hello.
Surely, you forgot to add the attribute OprCount. It is required for cyclic effects.
https://github.com/Albeoris/Memoria/wiki/Dictionary-Patch#user-content-BattleStatus

BattleStatus OprCount Add CustomStatus1

[charlie-in-spain]

Hello!
Yes, that was the cause indeed. I had added other attributes like "OutofBattle" but not that one, which is precisely used in the script... Thanks a lot! I've also tried with my custom status script and it's working too.

Now I've created a script for a custom item that heals this custom status. It's working in battle but not out of it, and the item has "Consumable" and "Usable" checked in HW. Maybe the script should be similar to "73 - ItemCureStatusScript" but I can't manage to set my custom status in the functions (since my custom status doesn't exist in HW). I guess it's only working in battle now because the code I'm using is:

btl_stat.RemoveStatus(_v.Target, BattleStatusId.CustomStatus1);

Is there any function I can use with my custom status as a parameter? Similar to _v.TryRemoveItemStatuses();.