Skip to content

fix: replace deprecated locale.getdefaultlocale() with getlocale() #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: replace deprecated locale.getdefaultlocale() with getlocale() #699

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1429a20
Update gui.py
No-22-Github Jun 24, 2025
2f56de1
Update gui.py
No-22-Github Jun 24, 2025
5ad4bc0
Update gui.py
No-22-Github Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ def run_tensorboard():
subprocess.Popen([sys.executable, "-m", "tensorboard.main", "--logdir", "logs",
"--host", args.tensorboard_host, "--port", str(args.tensorboard_port)])

def get_locale_compat():
lang = os.environ.get("LC_ALL") or os.environ.get("LC_CTYPE") or os.environ.get("LANG")
if lang:
lang = locale.normalize(lang).split('.')[0]
else:
lang = locale.getlocale()[0] or 'C'
return lang

@catch_exception
def run_tag_editor():
Expand All @@ -44,12 +51,11 @@ def run_tag_editor():
if args.localization:
cmd.extend(["--localization", args.localization])
else:
l = locale.getdefaultlocale()[0]
l = get_locale_compat()
if l and l.startswith("zh"):
cmd.extend(["--localization", "zh-Hans"])
subprocess.Popen(cmd)


def launch():
log.info("Starting SD-Trainer Mikazuki GUI...")
log.info(f"Base directory: {base_dir_path()}, Working directory: {os.getcwd()}")
Expand Down