Skip to content

Simplify field key assertions using set comparison #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify field key assertions using set comparison #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_aggify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ def test_filtering_and_projection(self):
aggify.filter(age__gte=30).project(name=1, age=1)
assert len(aggify.pipelines) == 2
assert aggify.pipelines[1]["$project"] == {"name": 1, "age": 1}
assert list(aggify.base_model._fields.keys()) == ["name", "age", "id"]
assert aggify.base_model._fields.keys() == {"name", "age", "id"}

def test_filtering_and_projection_with_deleting_id(self):
aggify = Aggify(BaseModel)
aggify.filter(age__gte=30).project(name=1, age=1, id=0)
assert len(aggify.pipelines) == 2
assert aggify.pipelines[1]["$project"] == {"_id": 0, "name": 1, "age": 1}
assert list(aggify.base_model._fields.keys()) == ["name", "age"]
assert aggify.base_model._fields.keys() == {"name", "age"}

def test_filtering_and_ordering(self):
aggify = Aggify(BaseModel)
Expand Down Expand Up @@ -644,7 +644,7 @@ def test_project_add_new_field(self):
aggify = Aggify(BaseModel)
thing = list(aggify.project(test="test", id=0))
assert thing[0]["$project"] == {"test": "test", "_id": 0}
assert list(aggify.base_model._fields.keys()) == ["test"]
assert aggify.base_model._fields.keys() == {"test"}

def test_lookup_raw_let(self):
aggify = Aggify(BaseModel)
Expand All @@ -662,7 +662,7 @@ def test_lookup_raw_let(self):
"pipeline": [{"$match": {"$expr": {"$eq": ["$name", "$$test"]}}}],
"as": "test_name",
}
assert "test_name" in list(aggify.base_model._fields.keys())
assert "test_name" in aggify.base_model._fields.keys()

def test_group_multi_expressions(self):
thing = list(Aggify(BaseModel).group(["name", "age"]))
Expand Down