fix: emit a note from _write_memory_on_failure - #115
Closed
andrewwhitecdw wants to merge 1 commit into
Closed
Conversation
_write_memory_on_failure accepted a note_fn argument that every caller passed, but it never invoked it. As a result, failure-memory updates were silent. Emit a note so observers can see when failure patterns are recorded. Adds a regression test that asserts note_fn is called when failure memory is written. Signed-off-by: Andrew White <andrewh@cdw.com>
|
|
AbirAbbas
approved these changes
Aug 10, 2026
AbirAbbas
left a comment
AbirAbbas
left a comment
Collaborator
There was a problem hiding this comment.
Code verified: note_fn was already threaded through all four call sites as an unused parameter, so wiring it up changes no signatures, and the new note only fires after the memory_fn is None guard — consistent with _write_memory_on_approve. The new test fails correctly on unpatched main. Approving the code.
Merge is held on the CLA — please sign via the CLA-assistant link above and this can land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this stale PR. Happy to reopen if the maintainers would like to revisit it.