Deeplinking playground - disable try button in mobile/tablet #176
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerxovksi
reviewed
Oct 20, 2025
| inset-inline-end: var(--spectrum-global-dimension-size-125); | ||
| } | ||
|
|
||
| .code-try-button.is-disabled { |
There was a problem hiding this comment.
Should we not just hide the Try Now button altogether instead of disabling it?
There was a problem hiding this comment.
This was suggested by Padma.
| // hover:none detects devices without hover capability (touch-only) | ||
| const cannotHover = window.matchMedia("(hover: none)").matches; | ||
|
|
||
| return hasCoarsePointer || cannotHover; |
There was a problem hiding this comment.
Is this a standard way of detecting mobile? How relaible is this?
There was a problem hiding this comment.
Added maxWidth check as well to make it more reliable.
Comment on lines
117
to
119
| const handleResize = () => setIsMobile(isMobileDevice()); | ||
| window.addEventListener("resize", handleResize); | ||
| return () => window.removeEventListener("resize", handleResize); |
There was a problem hiding this comment.
What is the need for this?
There was a problem hiding this comment.
Removed this.
xerxovksi
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deeplinking playground - disable try button in mobile/tablet
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: