Remove harmful warning Update plugins.md #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with Mage-OS. Around plugins are good and explicitly show up in a stack trace, performance degradation is minuscule by comparison with hours of debugging and understanding combinations of plugins. https://devdocs.mage-os.org/docs/main/plugins#content-2-after-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with Mage-OS.
Around plugins are good and explicitly show up in a stack trace, performance degradation is near-non-existent by comparison with hours of debugging and understanding combinations of plugins. https://devdocs.mage-os.org/docs/main/plugins#content-2-after-plugin
Purpose of this pull request
This pull request (PR) removes harmful message that questions competence of those who write
aroundplugins.Having plugin in the stack eliminates hours of debugging.
Current message forces people to break down into
beforeandafter, when it actually does not make sense.Thankfully Mage-OS did not keep this harmful statement.
Affected pages
Links to Magento Open Source code