image block with custom variant - #729
Open
petheanraj-mitrah wants to merge 1 commit into
Open
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-12T11:40:52.907Z |
davids-ensemble
requested changes
Aug 12, 2026
davids-ensemble
left a comment
Collaborator
There was a problem hiding this comment.
A few changes I would want to see implemented:
- let's call it "Standalone Image" instead of just "Image"
- let's require a caption:
- second row in the table or similar
- hide the caption by default (display: none)
- generate and set an
idon the caption - add
aria-labelledbyreferencing that id value to the image
Main reason for this is to align it with DevDocs' Image Block
In the future, if anyone will require it, we can offer an option to show the caption as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Image block with custom variant(medium and background color)
Jira
https://jira.corp.adobe.com/browse/DEVSITE-2519
Test URL
https://devsite-2519--adp-devsite-stage--adobedocs.aem.page/test/petheanraj/image