Sea Turtles - Heather M. - #14
Open
cathos wants to merge 5 commits into
Open
Conversation
tgoslee
reviewed
Apr 16, 2022
tgoslee
left a comment
tgoslee
left a comment
There was a problem hiding this comment.
Heather this was a great approach to the swap meet project! Your code was clean, efficient, and readable. I left a few comments on things you did great and things you can refactor. Let me know if you have any questions.
| pass No newline at end of file | ||
| from swap_meet.item import Item | ||
|
|
||
| class Clothing(Item): |
| pass No newline at end of file | ||
| from swap_meet.item import Item | ||
|
|
||
| class Decor(Item): |
| pass | ||
| from swap_meet.item import Item | ||
|
|
||
| class Electronics(Item): |
Comment on lines
+4
to
+18
| CATEGORIES = { | ||
| "": "Hello World!", | ||
| "Clothing": "The finest clothing you could wear.", | ||
| "Decor": "Something to decorate your space.", | ||
| "Electronics": "A gadget full of buttons and secrets.", | ||
| } | ||
|
|
||
| CONDITION_DESCRIPTORS = { | ||
| 0: "Oof. Are you sure you want this?", | ||
| 1: "Wow. It's pretty bad.", | ||
| 2: "Significant damage.", | ||
| 3: "Needs some love.", | ||
| 4: "Minor signs of wear or damage.", | ||
| 5: "So good it might be a scam.", | ||
| } |
There was a problem hiding this comment.
Heather great job making these global "constant" variables. This helps eliminate redundant code blocks and makes this accessible to other subclasses.
Comment on lines
+21
to
+29
| def __init__(self, category = "", condition = 0): | ||
| self.category = category | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): | ||
| return CATEGORIES[self.category] | ||
|
|
||
| def condition_description(self): | ||
| return CONDITION_DESCRIPTORS[int(self.condition)] No newline at end of file |
Comment on lines
+46
to
+47
| swap_items = self.inventory[my_item_index], vendor.inventory[their_item_index] | ||
| vendor.inventory[their_item_index], self.inventory[my_item_index] = swap_items |
There was a problem hiding this comment.
Great job on this streamlined approach. The add and remove methods are now just taking up space. I understand that you technically need them to pass the tests but just wanted to make that note.
| try: | ||
| my_item = self.inventory[0] | ||
| their_item = vendor.inventory[0] | ||
| self.swap_items(vendor, my_item, their_item) |
There was a problem hiding this comment.
great use of your previously created method.
| except: | ||
| return False | ||
|
|
||
| def get_best_by_category(self, category): |
Comment on lines
+88
to
+89
| my_item = self.get_best_by_category(their_priority) | ||
| their_item = other.get_best_by_category(my_priority) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.