C22 - Lorraine Shi and Charday Neal by chardayneal · Pull Request #19 · Ada-C22/swap-meet

chardayneal · 2024-10-04T01:05:11Z

No description provided.

…e comments

mikellewade · 2024-10-14T02:54:43Z

+        self.fabric = fabric
+        self.age = age
+
+    def __str__(self):


Notice that each __str__ method for Clothing, Decor, and Electronic all start with "An object of type [CLASSNAME] with id [ID].". Inside of Item we can have a __str__ method that print could return the part mentioned above and then pair that with the __str__ inside the child classes (Clothing, Decor, and Electronic). It could something like this:

class Item: ... def __str__(self): return f"An object of type {self.get_category()}" \ f" with id {self.id}." class Clothing(Item): ... def __str__(self): return f"{super().__str__()} It is made " \ f"from {self.fabric} fabric."

mikellewade · 2024-10-14T02:56:34Z

+    def __init__(self, id=None, fabric="Unknown",condition=0,age=0):
+        super().__init__(id,condition)
+        self.fabric = fabric
+        self.age = age


If all the children classes will have an attribute called age could we move this attribute into the parent class Item?

mikellewade · 2024-10-14T02:57:10Z

 class Item:
-    pass
+    def __init__(self, id=None,condition=0,age=0):
+        self.id = uuid4().int if id is None else id


mikellewade · 2024-10-14T02:57:42Z

+        self.age = age
+
+    def get_category(self):
+        return type(self).__name__


This could be written as self.__class__.__name__

mikellewade · 2024-10-14T02:58:12Z

+        if self.condition <= 2.0:
+            return "This is poor condition."
+        elif self.condition <= 4.0:
+            return "It is gently used."
+        elif self.condition > 4.0:
+            return "Fantastic condition!"


A perfect time to use match casing as well!

mikellewade · 2024-10-14T02:58:24Z

 class Vendor:
-    pass
+    def __init__(self, inventory=None):
+        self.inventory = [] if inventory is None else inventory


mikellewade · 2024-10-14T03:01:33Z

+        return None
+
+    def swap_items(self, other_vendor, my_item, their_item):
+        if my_item not in self.inventory or their_item not in other_vendor.inventory:


We could also use get_by_id to check if an item is in a given inventory and then check to see if that function returns None or the item.

mikellewade · 2024-10-14T03:02:13Z

+            return False
+
+        self.inventory.remove(my_item)
+        self.inventory.append(their_item)


Don't we have a method that adds items to an inventory? 👀 Might look simple here, but what happens if the structure of inventory changes?

mikellewade · 2024-10-14T03:02:35Z

+    def swap_first_item(self, other_vendor):
+        if not self.inventory or not other_vendor.inventory:
+            return False
+
+        my_first_item = self.inventory[0]
+        other_first_item = other_vendor.inventory[0]
+        self.swap_items(other_vendor, my_first_item, other_first_item)
+        return True


Great function!

mikellewade · 2024-10-14T03:02:54Z

+        return True
+
+    def get_by_category(self, category):
+        return [item for item in self.inventory if item.get_category() == category]


Omg list comprehension, love her!

mikellewade · 2024-10-14T03:03:22Z

+                best_condition_item = item
+
+        return best_condition_item
+        # return max(category_items, key=lambda item : item.condition)


Perfect use of a lambda function!

mikellewade · 2024-10-14T03:03:47Z

+    def swap_best_by_category(self, other_vendor, my_priority, their_priority):
+        my_swap_item = self.get_best_by_category(their_priority)
+        their_swap_item = other_vendor.get_best_by_category(my_priority)
+
+        if not my_swap_item or not their_swap_item:
+            return False
+        return self.swap_items(other_vendor, my_swap_item, their_swap_item)


mikellewade · 2024-10-14T03:04:05Z

+        my_swap_item = self.get_newest()
+        their_swap_item = other_vendor.get_newest()


mikellewade · 2024-10-14T03:05:52Z

+    assert len(fatimah.inventory) == 3
+    assert len(jolie.inventory) == 0


How could we alter these to make sure they check for the correct data structure as well.

mikellewade · 2024-10-14T03:06:28Z

+    assert tai.inventory == [item_a, item_b, item_c]
+    assert jesse.inventory == [item_d, item_e, item_f]


mikellewade · 2024-10-14T03:06:50Z

+    assert len(tai.inventory) == 3
+    assert len(jesse.inventory) == 3
+    assert tai.inventory == [item_c, item_b, item_f]
+    assert jesse.inventory == [item_e, item_d, item_a]


Great work here!

shiyinxi and others added 12 commits September 30, 2024 11:54

wave 01 completed except for test

16c929d

Complete wave 2 tests

34432fa

wave 03 completed with tests passed

01857c2

wave 01 test completed

ba527b7

wave 04 completed with tests passed

e6f34ea

wave 05 except condition_description function

98c392c

fix wave05

638d19f

Complete wave 6

7d2f504

Refactor functions with list comprehension and lambda function, delet…

48fd6f7

…e comments

add swap_by_newest function and tests created and passed

c41f61e

Remove max function from get_best_by_category

715f3d4

Merge branch 'main' of https://github.com/chardayneal/swap-meet

152348a

mikellewade reviewed Oct 14, 2024

View reviewed changes

chardayneal added 2 commits October 14, 2024 10:25

Update __str__() in Item class and subclasses

1e4ded7

Refactor condition_description function

189c802

chardayneal added 2 commits October 14, 2024 10:58

Refactor swap_items method

ca01589

Add asserts to test_swap_items_from_their_empty_returns_false()

0de2f2a

		my_swap_item = self.get_newest()
		their_swap_item = other_vendor.get_newest()

		assert len(fatimah.inventory) == 3
		assert len(jolie.inventory) == 0

		assert tai.inventory == [item_a, item_b, item_c]
		assert jesse.inventory == [item_d, item_e, item_f]

Conversation

chardayneal commented Oct 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants