Amethyst Abby Goodman & Winslow Edwards#67
Open
WinsEdwards wants to merge 31 commits into
Open
Conversation
ameerrah9
reviewed
Jun 26, 2023
ameerrah9
left a comment
ameerrah9
left a comment
There was a problem hiding this comment.
Great work, Abby + Winslow! 🥳
Thank you for your patience as we catch up on grading. Nice work! The HTML is structured well and the JS is clear and well-factored. This project is a Green. 🟢
Keep it up!
ameerrah9
reviewed
Jun 26, 2023
Comment on lines
+1
to
+6
| state = { | ||
| temp: 50, | ||
| city: "Atlanta", | ||
| latitude: 0, | ||
| longitude: 0 | ||
| }; |
ameerrah9
reviewed
Jun 26, 2023
| .then((response) => { | ||
| let tempK = response.data.main.temp | ||
| state.temp = Math.round(((tempK-273.15)*1.8) + 32) | ||
| console.log(response.data.main.temp) |
There was a problem hiding this comment.
Remember to remove debugging log statements
ameerrah9
reviewed
Jun 26, 2023
Comment on lines
+24
to
+25
| colorChanging(); | ||
| changeGround(); |
ameerrah9
reviewed
Jun 26, 2023
Comment on lines
+43
to
+44
| state.latitude = response.data[0].lat; | ||
| state.longitude = response.data[0].lon; |
ameerrah9
reviewed
Jun 26, 2023
Comment on lines
+57
to
+70
| const changeGround = function () { | ||
| if (state.temp <= 39) { | ||
| document.querySelector("#currentTemp") | ||
| const tempGroundContainer = document.querySelector("#groundChange") | ||
| tempGroundContainer.textContent = `❄️🌲❄️☃️❄️🏂❄️🌲❄️` | ||
| } | ||
|
|
||
| else if (state.temp >= 40 && state.temp <= 59) { | ||
| document.querySelector("#currentTemp") | ||
| const tempGroundContainer = document.querySelector("#groundChange") | ||
| tempGroundContainer.textContent = `🌬️ 🍂 🦃 🌾 🍂 🌰 🐿️ 🌾 🍂` | ||
| } | ||
|
|
||
| else if (state.temp >= 60 && state.temp <= 69){ |
There was a problem hiding this comment.
Great function naming, this looks really clean 💯 Your conditonal comprehension is very strong
ameerrah9
reviewed
Jun 26, 2023
| } | ||
| } | ||
|
|
||
| const colorChanging = function () { |
ameerrah9
reviewed
Jun 26, 2023
| } | ||
|
|
||
| const incrementTemp = function() { | ||
| state.temp +=1; |
There was a problem hiding this comment.
Prefer state.temp += 1 here for reada😄bility
ameerrah9
reviewed
Jun 26, 2023
| }; | ||
|
|
||
| const decrementTemp = function() { | ||
| state.temp -=1 |
There was a problem hiding this comment.
Prefer state.temp -= 1 here for readability
ameerrah9
reviewed
Jun 26, 2023
Comment on lines
+142
to
+145
| const getRealTimeTemp = function (){ | ||
| findLatitudeAndLongitude(); | ||
| colorChanging(); | ||
| changeGround(); |
ameerrah9
reviewed
Jun 26, 2023
| colorChanging(); | ||
| } | ||
|
|
||
| const newSKySelect = function () { |
ameerrah9
reviewed
Jun 26, 2023
| // colorChangeEffect.addEventListener("click", colorChangeEffect) | ||
| }; | ||
|
|
||
| document.addEventListener("DOMContentLoaded", registerEventHandlers); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.