solar_system Yasmin Leaves

[YasminM11]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	it runs when we create an object, it sets some values as part of creating an object(instance of the class)
Why do you imagine we made our instance variables readable but not writable?	Because we don't want to change the instance variable from outside the class
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	we can not build objects from hashes which will make our program longer and not organize
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	array store items only in order but hashes store values and keys
There is a software design principle called the SRP. The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	yes, my code follow just follow one class
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	on the top of the pages main

[beccaelenzil]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	Remove extra white apce
Variable names	check
Git hygiene	You'll probably want to start committing is smaller commits. (ie. When you finish making the planet class, when you make the planet_details method, etc.) It's a hard habit to get into but as the projects get bigger, things will get harder to keep track of and you'll break something and you'll want a recent working version to go back to.
Planet
initialize method stores parameters as instance variables with appropriate reader methods	check
summary method returns a string	check
SolarSystem
initialize creates an empty list of planets	check
add_planet takes an instance of Planet and adds it to the list	check
list_planets returns a string	check
find_planet_by_name returns the correct instance of Planet	check
CLI	This wave was not required
Can list planets and quit	N/A
Can show planet details	N/A
Can add a planet	Not required
Complex functionality is broken out into separate methods	N/A
Overall	Good job overall. I am glad you were able to focus on and meet the learning goals of defining classes and using composition.

[beccaelenzil]

Only have a single space between method definitions

[beccaelenzil]

This is a small detail, but you should remove extra lines of code.

[beccaelenzil]

remove this space

[beccaelenzil]

You could consider putting this planets in an array, and iterating over that array using each to puts each one.