Leaves -- Janice#41
Open
jaitch wants to merge 14 commits into
Open
Conversation
…ons so half-baked
…s don't disappear with solar system reset
Solar SystemWhat We're Looking For
|
dHelmgren
reviewed
Aug 30, 2019
| found_planet = find_planet_by_name(planet_sought) | ||
| while found_planet.class == Array | ||
| puts "Sorry, I don't recognize that planet. Please try again." | ||
| print "Which planet are you curious about? " |
There was a problem hiding this comment.
let your cli handle this puts-type stuff, to keep this more of a single responsibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod run? What does it do?initializemethod runs when I create a new instance of the Planet or Solar System class. It calls thenewmethod and hands it a bunch of information.Hashinstead of an instance of a class?Hashwould be cumbersome and confusing.SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?mainhas therequirestatements, because that is the file pulling in information from the other others. I could have had a hierarchy, wheremainpulled fromsolar_systemandsolar_systempulled fromplanet.