Skip to content

Branches - Mira#23

Open
calopter wants to merge 1 commit into
Ada-C12:masterfrom
calopter:master
Open

Branches - Mira#23
calopter wants to merge 1 commit into
Ada-C12:masterfrom
calopter:master

Conversation

@calopter

Copy link
Copy Markdown

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? My initial idea was to store each line in its own hash with the column names as keys, but then I saw that each question involves drivers, so I decided to try building that into the data representation. I'm not sure how much it helped.
What was your strategy for going through the data structure and gathering information? Nesting and/or chaining method calls. I would prefer to chain them more but am not sure in what class it would be best to define them, so I avoided the issue with top-level method defs.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? It was necessary to store the outer data structure in a variable in order to clearly reference it in multiple locations, allowing me to iterate through it multiple times to answer the questions.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? I mostly used Enumerable methods, sometimes nested in method calls. I use .map once to define .sum_by, which I use in various places.
Were some calculations easier than others? Why? Some involved more nesting of loops to access the relevant information because of how I structured the data

@calopter calopter changed the title complete rideshare Branches - Mira Aug 12, 2019

@kaidamasaki kaidamasaki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes. 😄

@kaidamasaki

kaidamasaki commented Aug 20, 2019

Copy link
Copy Markdown

Ride Share

What We're Looking For

Feature Feedback
Answers the comprehension questions 👍🏼
Readable code with consistent indentation and reasonable code style 👍🏼
Outputs the correct number of rides each driver has given 👍🏼
Outputs the total amount of money each driver has made 👍🏼
Outputs the average rating for each driver 👍🏼 (though you didn't round to hundredths so the output is a little funny)
Outputs which driver made the most money 👍🏼

Outputs which driver has the highest average rating | 👍🏼

Well done! Your solution is clean and concise and make good use of Enumerable methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants