Leaves--Janice#39
Open
jaitch wants to merge 15 commits into
Open
Conversation
…th arrays for values and finding keys (point values) by searching those array then finding corresponding keys
JS AdagramsWhat We're Looking For
|
| shuffle, | ||
|
|
||
| drawLetters() { | ||
| // Implement this method for wave 1 |
There was a problem hiding this comment.
Here, you shuffle the entire array pool of letters... and then, you take the first ten. Consider refactoring this so that you randomly pick ten letters, instead of shuffling the entire array.
| scoreWord, | ||
|
|
||
| highestScoreFrom(words) { | ||
| let wordCollection = []; |
There was a problem hiding this comment.
Consider using comments to outline your logic here. There's a lot going on, there may be an opportunity for a helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions
ifandwhilereturnout of a forEach!