Leaves - Alice#33
Open
sun-alice wants to merge 5 commits into
Open
Conversation
| const Adagrams = { | ||
| drawLetters() { | ||
| // Implement this method for wave 1 | ||
| let letterPool = ( |
There was a problem hiding this comment.
Consider first creating an object that represents letter frequencies and then using this object to build your array.
| let points = 0; | ||
|
|
||
| for (let letter in split) { | ||
| switch (split[letter]) { |
There was a problem hiding this comment.
Good approach using a switch/case conditional! You probably could refactor this to use an object (a hash) though.
| ).split(""); | ||
| let hand = []; | ||
|
|
||
| for (let i = 0; i < 10; i++) { |
There was a problem hiding this comment.
You're modifying your letterPool here. Make sure to make a deep copy first. In addition, consider how you could refactor such that you don't shuffle the pool 10 times.
JS AdagramsWhat We're Looking For
|
beccaelenzil
added a commit
to beccaelenzil/js-adagrams
that referenced
this pull request
Jun 2, 2022
change npm to yarn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions