Skip to content

Branches - Farah - #33

Open
in-formation wants to merge 2 commits into
Ada-C12:masterfrom
in-formation:master
Open

Branches - Farah#33
in-formation wants to merge 2 commits into
Ada-C12:masterfrom
in-formation:master

Conversation

@in-formation

Copy link
Copy Markdown

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? It catches the exception(error) when it occurs as opposed to just shutting down the program when the ArgumentError is raised(occurs).
Why do you think we made the .all & .find methods class methods? Why not instance methods? Making these methods class methods allows information from all the class instances to be accessed as opposed to the information only associated with one class instance.
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? It seems to me like a one-to-many relationship. There is one Customer to many orders. It is is similar of a relationship to Solar System because it is well known that there is only one solar system each planet can be a part of. It is a one(solar system)-to-many(planets) relationship.
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? The order data in the CVS file shows which Customer IDs put the order in. Those customer IDs come from the Customer.csv file which contains all the customer information. In my program it is tracked in a hash first when assessing the customer.csv file and then again in a hash when the order information is processed.
Did the presence of automated tests change the way you thought about the problem? How? I'm not exactly clear on what tests were automated but if we are discussing the mini tests then yes it completely changed the way I tackled the problem. It allowed me to go step by step assessing each test at a time as a milestone of whether or not to continue writing the main code.

@jmaddox19

Copy link
Copy Markdown

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly Definitely suggest getting in the habit of committing in much smaller pieces
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables X
Wave 2
All stubbed tests are implemented fully and pass X
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all X
Order.all calls Customer.find to set up the composition relation X
Additional Notes Looks great! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants