Skip to content

Branches - Macaria #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdove92 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −3
Open

Branches - Macaria #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/binary_to_decimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
# A method named `binary_to_decimal` that receives as input an array of size 8.
# A method named `binary_to_decimal` that
#receives as input an array of size 8.
# The array is randomly filled with 0’s and 1’s.
# The most significant bit is at index 0.
# The least significant bit is at index 7.
# Calculate and return the decimal value for this binary number using
# Calculate and return the decimal value for
# this binary number using
# the algorithm you devised in class.

def binary_to_decimal(binary_array)
raise NotImplementedError
index = binary_array.length - 1
result = 0
while index >= 0
result += binary_array[index] * (2 ** (7 - index))

@CheezItMan CheezItMan Sep 3, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest making 7 a constant or using the binary_array.length -1 just to make the code a bit more flexible. Using specific numbers like 7 in code are sometimes called "magic numbers".

index -= 1
end
return result
end