[DO NOT MERGE] Deployment Branch#4
Conversation
…o better meet AWS needs
mikellewade
left a comment
mikellewade
left a comment
There was a problem hiding this comment.
Tests are failing to build, plus the removed sectioned of the README that can come back.
|
|
||
|
|
||
| secrets_client = boto3.client('secretsmanager') | ||
| secret = secrets_client.get_secret_value(SecretId=os.environ.get('DB_SECRET_ARN')) |
There was a problem hiding this comment.
This created some issues for me since the lab document states for it to be called DATABASE_SECRET_ARN
| DB_HOST = os.environ.get('DATABASE_HOST') | ||
| DB_PORT = int(os.environ.get('DATABASE_PORT', 5432)) | ||
| DB_NAME = os.environ.get('DATABASE_NAME') | ||
| DB_USER = os.environ.get('DATABASE_USER') | ||
|
|
||
|
|
||
| secrets_client = boto3.client('secretsmanager') | ||
| secret = secrets_client.get_secret_value(SecretId=os.environ.get('DATABASE_SECRET_ARN')) |
There was a problem hiding this comment.
Realizing that none of the tests are passing here. I think it has something to do with the secrets manager code running in the tests. Might want to have some type of conditional set up to where this code doesn't run if we are in a testing environment.
| ## Running the SQS Consumer | ||
|
|
||
| ```bash | ||
| python -m app.consumers.consumer | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This section can come back since code would have been implemented here.
mikellewade
left a comment
mikellewade
left a comment
There was a problem hiding this comment.
LGTM, just needs the consumer logic section added back to the README.
2 participants
Created a branch for the deployment Lab with the following revisions: