Skip to content

Conversation

@yruslan
Copy link
Collaborator

@yruslan yruslan commented Nov 2, 2025

Summary by CodeRabbit

  • Chores
    • Updated Spark to 3.5.7
    • Updated Scala to 2.13.17
    • Updated ScalaTest to 3.2.19
    • Updated Jackson to 2.13.5
    • Bumped example project versions and README build commands to match
    • Simplified build config by removing unused plugins and properties

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025

Walkthrough

The pull request updates dependency and build configuration versions across the repository: Scala 2.13.16 → 2.13.17, Spark variants to 3.5.7, Jackson to 2.13.5, and ScalaTest to 3.2.19. Several Maven build-related properties and plugins were removed from the root POM; no public API or runtime control flow was changed.

Changes

Cohort / File(s) Summary
CI Configuration
\.github/workflows/build.yml
Updated Spark matrix entry from 3.5.53.5.7 and adjusted corresponding exclusion entries.
Example Project Dependencies
examples/spark-cobol-app/build.sbt, examples/spark-cobol-app/pom.xml
Bumped Spark version to 3.5.7 and ScalaTest to 3.2.19 in both SBT and Maven files.
Project Scala version references & README
build.sbt, README.md
Updated Scala 2.13 reference from 2.13.162.13.17 (build constant and README build/shell examples).
Main Project POM
pom.xml
Removed Maven build-related properties (maven.release.version, maven.scm.provider.gitexe.version, maven.gpg.plugin.version, scala_logging.version); updated spark.version3.5.7 and jackson.version2.13.5; removed maven-source-plugin, maven-release-plugin, and maven-gpg-plugin declarations.
Dependency definitions
project/Dependencies.scala
Updated jacksonVersion to 2.13.5 and default Spark version for Scala 2.13 from 3.5.63.5.7.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Pay extra attention to the root pom.xml removals (plugins and properties) and any CI/release workflows that may rely on them.
  • Verify consistency of Spark versions across all build files (examples, project properties, CI).
  • Validate Jackson/JVM dependency alignment between pom.xml and project/Dependencies.scala.
  • Confirm README and build constants match actual published artifacts for Scala 2.13.17.

Poem

🐇 I hopped through files with versions in tow,

Scala nudged up, Spark learned to glow,
Jackson polished, plugins went away,
Examples and CI joined the new day —
A tiny hop for code, a happier flow. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Update several dependencies" accurately describes the primary objective of the changeset. The pull request systematically updates multiple dependencies across several configuration files, including Scala (2.13.16 → 2.13.17), Spark (3.5.5/3.5.6 → 3.5.7), Jackson (2.13.0/2.13.4 → 2.13.5), and ScalaTest (3.2.14 → 3.2.19), along with removing some Maven plugin declarations. The title is concise, clear, and avoids unnecessary noise. While it doesn't specify which dependencies are updated, it remains specific enough to distinguish this change from other types of updates and would allow teammates reviewing the git history to understand the intent of the PR.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/update-dependencies

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 137016d and 95ee636.

📒 Files selected for processing (7)
  • .github/workflows/build.yml (1 hunks)
  • README.md (2 hunks)
  • build.sbt (1 hunks)
  • examples/spark-cobol-app/build.sbt (1 hunks)
  • examples/spark-cobol-app/pom.xml (1 hunks)
  • pom.xml (1 hunks)
  • project/Dependencies.scala (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • examples/spark-cobol-app/pom.xml
  • project/Dependencies.scala
  • examples/spark-cobol-app/build.sbt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test (2.12.20, 2.12, 3.3.4, 0, 80, 20)
  • GitHub Check: Spark 3.4.4 on Scala 2.12.20
  • GitHub Check: Spark 3.5.7 on Scala 2.13.17
  • GitHub Check: Spark 2.4.8 on Scala 2.11.12
  • GitHub Check: Spark 3.5.7 on Scala 2.12.20
🔇 Additional comments (4)
README.md (1)

309-331: LGTM! Documentation accurately reflects the version updates.

The Scala 2.13 version bump from 2.13.16 to 2.13.17 is correctly reflected in the build command examples. These documentation changes align with the actual code changes in build.sbt.

.github/workflows/build.yml (1)

22-34: LGTM! CI matrix correctly updated for new dependency versions.

The build matrix properly reflects the Scala 2.13.17 and Spark 3.5.7 updates, with exclusions correctly adjusted to maintain valid version combinations.

build.sbt (1)

24-24: LGTM! Scala 2.13 version appropriately updated.

The Scala 2.13 version bump is cleanly applied and will propagate correctly throughout the build configuration.

pom.xml (1)

107-110: Dependency updates verified—no breaking changes identified.

Spark updated to 3.5.7 (maintenance release) and Jackson to 2.13.5 (patch release). Both are safe updates with bug and security fixes only.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

JaCoCo code coverage report - 'cobol-parser'

Overall Project 91.73% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

JaCoCo code coverage report - 'spark-cobol'

There is no coverage information present for the Files changed

Total Project Coverage 80.16% 🍏

@yruslan yruslan force-pushed the feature/update-dependencies branch from 137016d to 95ee636 Compare November 2, 2025 12:27
@yruslan yruslan merged commit ad6729a into master Nov 2, 2025
7 checks passed
@yruslan yruslan deleted the feature/update-dependencies branch November 2, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants