Skip to content

Support persian characters#4

Open
hmmftg wants to merge 9 commits into
AbdullahDiaa:mainfrom
hmmftg:main
Open

Support persian characters#4
hmmftg wants to merge 9 commits into
AbdullahDiaa:mainfrom
hmmftg:main

Conversation

@hmmftg

@hmmftg hmmftg commented Jul 4, 2023

Copy link
Copy Markdown

No description provided.

@ravarage

ravarage commented Sep 7, 2023

Copy link
Copy Markdown

I will test this against Kurdish chars, they are mostly either Arabic or persian thank you

@ravarage

ravarage commented Sep 9, 2023

Copy link
Copy Markdown

I don't know what you did, I tried this and a lot of thing even in Arabic got broken, so I made my own solution, I want to compare accuracy with original library, not this fork, guess what?, the original beside missing chars, it is working great, now my solution does support Persian too, not sure if I should release it or add it to this library, I will do some benchmark and compare success rate between them, then I decide
it support Arabic, Urdu,Persian and Kurdish
it support remove harakat , shift harakat, remove tatweel , zero width chars and use unshaped instead of isolate

@hmmftg

hmmftg commented Oct 9, 2023

Copy link
Copy Markdown
Author

I don't know what you did, I tried this and a lot of thing even in Arabic got broken, so I made my own solution, I want to compare accuracy with original library, not this fork, guess what?, the original beside missing chars, it is working great, now my solution does support Persian too, not sure if I should release it or add it to this library, I will do some benchmark and compare success rate between them, then I decide it support Arabic, Urdu,Persian and Kurdish it support remove harakat , shift harakat, remove tatweel , zero width chars and use unshaped instead of isolate

can you commit your changes to let us now your solution?

@ravarage

Copy link
Copy Markdown

https://github.com/ravarage/go-arabic-reshaper
its very slow compare to this solution, just by making it one loop it improve the performance by %50, I Will try to make it feature reach by adding linguist chars but for right now I am too busy , and this got the job done for me

@DearRude

Copy link
Copy Markdown

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants