Skip to content

Calculator milimade branch#2

Open
MiliMade wants to merge 3 commits intoAbbeyIT:mainfrom
MiliMade:calculator-milimade-branch
Open

Calculator milimade branch#2
MiliMade wants to merge 3 commits intoAbbeyIT:mainfrom
MiliMade:calculator-milimade-branch

Conversation

@MiliMade
Copy link
Copy Markdown

@MiliMade MiliMade commented Oct 1, 2022

🛠️ Fixes Issue

👨‍💻 Changes proposed

⚙️ How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A : Clicked on the button to see if the value changed between negative and positive.
  • [] Test B

✔️ Check List

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

MiliMade and others added 3 commits October 1, 2022 00:04
I added "let haveNegative = false" on line 23 but ended up not having use for it.
@AbbeyIT AbbeyIT self-requested a review October 5, 2022 04:55
Copy link
Copy Markdown
Owner

@AbbeyIT AbbeyIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiliMade The negate is working on the calculator screen. When clicked number can be positive or negative but on my side it is not working when doing calculations meaning when I do some operations. For example 10 + -2 will be equal to 12 when it should be 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants