feat: enable F32 output in CpuGemmConv2d #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
5 times, most recently
from
d0ad533 to
20c80c0
Compare
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
from
20c80c0 to
976a634
Compare
gunes-arm
requested changes
Oct 3, 2025
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
4 times, most recently
from
02cc3e6 to
4c780b3
Compare
gunes-arm
reviewed
Oct 7, 2025
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
3 times, most recently
from
6a8b64a to
88c1594
Compare
gunes-arm
requested changes
Oct 7, 2025
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
3 times, most recently
from
780b190 to
950a00b
Compare
- Updated convolution reference to branch epilogue:
* TO=float: int32 to float dequant (acc * sA * sB + bias_f32)
* TO!=float: usual quantize_down_scale_by_fixedpoint with int32 bias
- Changed fixture to use F32 bias tensor for Q->F32 runs (instead of S32),
matching arm_gemm dequant epilogue which only supports float bias.
- Added explicit template instantiations for convolution_layer with
TBias=float, TO=float to fix linker errors in validation.
- Disabled activation in arm_gemm dequant path:
offsets are applied afterwards by CpuGemmLowpOffsetContributionKernel,
so activation must run there to see the correct final accumulator.
- src/cpu/kernels/gemmlowp/generic/neon/impl.h
neon_run_offset_contribution_float(): replace per-batch offset
for vector_sum_col from Y stride to W stride.
This aligns target and reference for quantized to F32 convolution tests
and prevents premature clamping before offset contributions.
Change-Id: I6fffc98dc0798542a2702e6a593b850c16561e3b
Signed-off-by: Pablo Marquez Tello <[email protected]>
morgolock
force-pushed
the
pr/conv_f32_dequant
branch
from
950a00b to
b8824c1
Compare
gunes-arm
reviewed
Oct 16, 2025
gunes-arm
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns target and reference for quantized to F32 convolution tests and prevents premature clamping before offset contributions.
Change-Id: I6fffc98dc0798542a2702e6a593b850c16561e3b