Fix Wipe table height drifting across resets#816
Merged
Abhiram824 merged 2 commits intoJul 11, 2026
Merged
Conversation
Member
|
Hi, change looks good. can you remove the extra test file and I will approve |
Contributor
Author
|
Removed, thanks! |
Abhiram824
self-requested a review
July 11, 2026 22:44
Abhiram824
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #815 (🐛 Bug).
In
Wipe,self.table_offset[2] += self.delta_heightran on every_load_modelwhiledelta_heightwas sampled only once (guarded byis None). Sincetable_offsetis a persistent array, the table height accumulated a fixed delta each reset (a linear ramp), andtable_height_stdproduced no per-episode variation after the first episode.Now the base offset is stored once at init and each reset sets
table_offset[2] = base + N(table_height, table_height_std), so the height is re-sampled per episode and never drifts.How it was tested
Added
test_wipe_table_height_no_driftintests/test_environments/test_wipe_table_height.py: withtable_height_std=0.02the resets no longer ramp, stay centered on the base height, and vary per episode; with the defaultstd=0.0the height stays fixed (no regression).Before:
table_offset[2]over 6 resets ramped0.930 -> 0.945 -> ... -> 1.004. After: bounded and varying, e.g.0.926, 0.923, 0.867, 0.912, ....How to checkout & try?