Skip to content

Upgrade project to Vite 8 and update dependencies #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arbaaz123676 wants to merge 3 commits into from
Closed

Upgrade project to Vite 8 and update dependencies #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c36b5
feat: implement cursor follow interaction for screen mirror (#343)
May 1, 2026
4a9c122
fix: prevent cursor teleport during scroll gestures and throttle poin…
Arbaaz123676 May 3, 2026
93205fe
feat: upgrade to Vite 8 and ensure without breaking anything
Arbaaz123676 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"$schema": "https://biomejs.dev/schemas/2.4.14/schema.json",

"vcs": {
"enabled": false,
Expand All @@ -9,18 +9,22 @@

"files": {
"ignoreUnknown": false,
"include": ["src/**/*", ".vscode/**/*", "index.html", "vite.config.ts"],
"ignore": ["src/routeTree.gen.ts", "src/styles.css"]
"includes": [
"src/**/*",
".vscode/**/*",
"index.html",
"vite.config.ts",
"!src/routeTree.gen.ts",
"!src/styles.css"
]
Comment on lines +12 to +19
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Biome files.includes negation pattern documentation ** first entry

💡 Result:

In Biome, the first-entry documentation for negation patterns under files.includes is: “includes also supports negated patterns, or exceptions. These are patterns that start with ! … When using a negated pattern, you should always specify first to match all files and folders, otherwise the negated pattern will not match any files.” Example from the docs: { "files": { "includes": ["", "!/*.test.js", "/special.test.js", "!test"] } } This means ! entries in files.includes are “exceptions” that stop Biome from processing paths that match them, but they require a preceding positive include like (and exceptions are applied in order).

Citations:

Add ** as the first entry in files.includes to enable the negation patterns to work correctly.

The Biome documentation specifies: "When using a negated pattern, you should always specify ** first to match all files and folders, otherwise the negated pattern will not match any files." Without ** as the first entry, the negation patterns !src/routeTree.gen.ts and !src/styles.css will silently have no effect, causing the auto-generated route tree file to be processed by the linter and formatter.

Proposed fix 
 	"files": {
 		"ignoreUnknown": false,
 		"includes": [
+			"**",
 			"src/**/*",
 			".vscode/**/*",
 			"index.html",
 			"vite.config.ts",
 			"!src/routeTree.gen.ts",
 			"!src/styles.css"
 		]
 	},
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@biome.json` around lines 12 - 19, The includes array in biome.json is missing
the glob "**" as the first entry so the negation patterns
(!src/routeTree.gen.ts, !src/styles.css) don't take effect; update the
files.includes array to insert "**" as the first entry (before "src/**/*") so
Biome will match all files first and then correctly apply the negations to
exclude src/routeTree.gen.ts and src/styles.css.

},

"formatter": {
"enabled": true,
"indentStyle": "tab"
},

"organizeImports": {
"enabled": false
},
"assist": { "actions": { "source": { "organizeImports": "off" } } },

"linter": {
"enabled": true,
Expand Down
Loading
Loading