Skip to content

Conversation

@jrmadsen
Copy link
Collaborator

Was reviewing some Omniprobe code and provided a "starter" implementation of using rocprofiler-sdk. I didn't check if it compiled so may have missed something minor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a starter implementation for integrating the rocprofiler-sdk into the Omniprobe interceptor by registering callbacks and updating the build.

  • Introduces SDK headers and implements initialization, finalization, and API registration callbacks in interceptor.cc.
  • Updates CMakeLists to find and link against the rocprofiler-sdk package.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/interceptor.cc Adds rocp_sdk_tool_init, rocp_sdk_tool_fini, and registration logic
src/CMakeLists.txt Adds find_package(rocprofiler-sdk) and links rocprofiler-sdk::rocprofiler-sdk
Comments suppressed due to low confidence (2)

src/interceptor.cc:1005

  • [nitpick] The callback name rocp_sdk_api_registration_callback is generic. A more descriptive name (e.g. on_hsa_table_registration) would improve readability.
void

src/CMakeLists.txt:52

  • [nitpick] It may be helpful to update the project README or docs/ to document the new rocprofiler-sdk dependency and any required installation steps.
find_package(rocprofiler-sdk REQUIRED)

jrmadsen and others added 2 commits June 23, 2025 21:18
- includes and missing return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants