Docs Update: Perf Model Add and Local Test Run Instructions #389
Open
spandoesai wants to merge 2 commits intomainfrom
Open
Docs Update: Perf Model Add and Local Test Run Instructions #389spandoesai wants to merge 2 commits intomainfrom
spandoesai wants to merge 2 commits intomainfrom
Conversation
ajassani
requested changes
Oct 16, 2025
| # ... parse other params as needed | ||
| return { 'q_shape': q_shape, 'k_shape': k_shape, 'v_shape': v_shape, 'dropout': dropout } | ||
|
|
||
| @staticmethod |
Collaborator
There was a problem hiding this comment.
this will override the base class method i believe, so we should not have this
|
|
||
| --- | ||
|
|
||
| ## Example: Adding a New Attention Perf Model |
Collaborator
There was a problem hiding this comment.
this is mostly repeated content from just above
| ```python | ||
| class my_attention_forward(SDPA): | ||
| def get_param_details(self, event): | ||
| # Example: change indices to match your op's argument order |
Collaborator
There was a problem hiding this comment.
can we add a real world example of the src function signature and how we get the indices from there?
maybe we can use tri dao flash attention or something like that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation for:
[Closes #357 , closes #310 ]