refactor(config): prune megatron trainer defaults and preserve CLI override compatibility#589
Open
WangLingxun wants to merge 1 commit intomainfrom
Open
refactor(config): prune megatron trainer defaults and preserve CLI override compatibility#589WangLingxun wants to merge 1 commit intomainfrom
WangLingxun wants to merge 1 commit intomainfrom
Conversation
Collaborator
WangLingxun
commented
Mar 10, 2026
WangLingxun
commented
- Remove redundant/null entries from megatron/trainer_base.yaml to simplify the preset and reduce maintenance noise.
- Update launcher parsing to allow Megatron override passthrough, keeping CLI-driven configuration backward-compatible after preset key cleanup.
WangLingxun
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
…erride compatibility - Remove redundant/null entries from megatron/trainer_base.yaml to simplify the preset and reduce maintenance noise. - Update launcher parsing to allow Megatron override passthrough, keeping CLI-driven configuration backward-compatible after preset key cleanup.
WangLingxun
force-pushed
the
refactor/megatron-config-override-compat
branch
from
08b589e to
073be7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.