Repository navigation
Conversation
…rical python file, moved constants to a single file, remove ancil_target_path from flow.cylc
Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com>
…to common constants file
…ylc.flow and package to pass only the necessary arguments (filenames and dirpaths). Deleted the empty python files.
…ectory and filename separate. Moved input_filepath to variables.cylc
atteggiani
reviewed
Oct 2, 2026
atteggiani
left a comment
atteggiani
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @mvgarcia for opening this PR.
The picontrol addition looks good.
I have only one comment below.
One bigger matter about this experiment (and some other similar ones that need to patch namelists) is the whole namelists patching. However, this needs proper discussion and we'll probably handle it in a dedicated meeting.
Thank you for your contributions! :)
| patch_str_namelist = parser.reads(patch_str) | ||
|
|
||
| # Create a new namelist by patching the original namelist | ||
| pi_solar_namelist_filepath = Path("atmosphere") / "input_atm.nml" |
Collaborator
There was a problem hiding this comment.
This hardcoded information should be passed as an input argument.
Something like -O atm_namelist_filepath="{{ ATM_NAMELIST_FILEPATH }}" (defining ATM_NAMELIST_FILEPATH in variables.cylc)
And the used here like
atm_namelist_filepath = request.options["atm_namelist_filepath"]
atteggiani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored pi control. No unit tests yet