feat: Migrate examples to built-in Kotlin and iOS SPM path - #431
Open
ziqq wants to merge 2 commits into
Open
Conversation
|
To preview the documentation for this pull request, visit the following URL: docs.page/abausg/home_widget~431
|
WalkthroughMigrates ChangesBuilt-in Kotlin & SPM Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/migrations/built-in-kotlin.mdx (1)
35-37: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winVary sentence starters in the checklist items to improve readability.
The three list items (lines 35–37) each begin with "Your", which violates style guidance. Consider rewording to vary the sentence structure:
Suggested fix
- 1. Your project builds with the Flutter version required by `home_widget`. - 2. Your Android project uses a recent AGP version. - 3. Your widget app still builds successfully with `flutter build apk` or `flutter build appbundle`. + 1. Verify your project builds with the Flutter version required by `home_widget`. + 2. Your Android project uses a recent AGP version. + 3. Ensure your widget app still builds successfully with `flutter build apk` or `flutter build appbundle`.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/migrations/built-in-kotlin.mdx` around lines 35 - 37, The three checklist items in the prerequisites section all begin with "Your", creating repetitive sentence structure that reduces readability. Reword each of the three items to vary the sentence starters: the first item about Flutter version compatibility, the second item about AGP version, and the third item about the widget app build success. Use different grammatical constructions such as starting with verbs, adjectives, or restructuring as necessary to create variety while maintaining clarity and conciseness.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/migrations/built-in-kotlin.mdx`:
- Around line 35-37: The three checklist items in the prerequisites section all
begin with "Your", creating repetitive sentence structure that reduces
readability. Reword each of the three items to vary the sentence starters: the
first item about Flutter version compatibility, the second item about AGP
version, and the third item about the widget app build success. Use different
grammatical constructions such as starting with verbs, adjectives, or
restructuring as necessary to create variety while maintaining clarity and
conciseness.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 976977b8-5353-4d67-901c-f16d0556c580
📒 Files selected for processing (22)
.github/workflows/main.ymlCHANGELOG.mddocs.jsondocs/features/interactive-widgets.mdxdocs/migrations/built-in-kotlin.mdxdocs/setup/android.mdxdocs/setup/ios.mdxexamples/configurable_widget/android/app/build.gradle.ktsexamples/configurable_widget/android/settings.gradle.ktsexamples/file_and_images/android/app/build.gradle.ktsexamples/file_and_images/android/gradle.propertiesexamples/file_and_images/android/settings.gradle.ktsexamples/generator_basics/android/app/build.gradle.ktsexamples/generator_basics/android/settings.gradle.ktspackages/home_widget/CHANGELOG.mdpackages/home_widget/android/build.gradlepackages/home_widget/example/android/app/build.gradlepackages/home_widget/example/android/gradle/wrapper/gradle-wrapper.propertiespackages/home_widget/example/android/settings.gradlepackages/home_widget/example/ios/Podfilepackages/home_widget/example/ios/Runner.xcodeproj/project.pbxprojpackages/home_widget/ios/home_widget/Package.swift
💤 Files with no reviewable changes (3)
- examples/file_and_images/android/gradle.properties
- packages/home_widget/example/ios/Podfile
- packages/home_widget/example/ios/Runner.xcodeproj/project.pbxproj
ziqq
changed the title
ziqq
changed the title
ziqq
changed the title
Author
|
I can't see build logs on codemagic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: migrate examples to built-in Kotlin and iOS SPM path
Description
This PR completes the Android built-in Kotlin migration for
home_widgetand aligns the package example with the iOS Swift Package Manager integration path.On Android,
home_widgetno longer keeps the legacy Kotlin Gradle Plugin compatibility fallback. The plugin now relies on Flutter's built-in Kotlin path, and the oldandroid.builtInKotlin=false/android.newDsl=falsecompatibility mode is no longer supported.On iOS, the package example is updated to use the Swift Package Manager integration path instead of directly wiring
pod 'home_widget'into the widget extension. The PR also updates repository examples, migration docs, setup docs, changelog entries, and CI guardrails so the documented setup matches the current implementation.Validated with:
melos testflutter build apk --releaseinpackages/home_widget/exampleflutter build ios --release --no-codesigninpackages/home_widget/exampleflutter build apk --releaseinexamples/configurable_widgetChecklist
exampleor documentation.Breaking Change?
Migration instructions
To migrate from the current release:
android.builtInKotlin=falseandandroid.newDsl=falsefrom your Androidgradle.propertiesif they are still present.Related Issues
None.