Skip to content

Conversation

@Tehsurfer
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests that prove my fix is effective or that my feature works

Tehsurfer added 13 commits May 20, 2021 16:09
 - Bug fix for some datasets not returning _any_ objects
 - Switch scicrunch-query-string from using the route to using URL
   params (this is now implemented in tehsurfer/map-side-bar)
Previously there was no check to make sure we made it to the end of our
desired attributes. This has now been added along with some comments to
explain what is going on
dbrnz pushed a commit to dbrnz/sparc-api that referenced this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant