fix: Handle string entities/edges in _validate_and_process#73
Open
calvinguo721 wants to merge 1 commit into666ghj:mainfrom
Open
fix: Handle string entities/edges in _validate_and_process#73calvinguo721 wants to merge 1 commit into666ghj:mainfrom
calvinguo721 wants to merge 1 commit into666ghj:mainfrom
Conversation
Add type checking to prevent crashes when LLM returns malformed JSON
where entity_types or edge_types contain strings instead of dicts.
- Wrap string entities into {name, description} format
- Skip invalid (non-dict) entries
- Collect valid entries into new lists
Fixes TypeError: 'str' object does not support item assignment
dosubot
bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When LLM returns malformed JSON where
entity_typesoredge_typescontain strings instead of dictionaries, the_validate_and_processmethod crashes with:Solution
Added type checking in
_validate_and_process:Testing
Tested with DeepSeek model via OpenRouter. Successfully generates ontology without crashes.