fix(frontend): use relative baseURL in production, avoid hardcoded localhost#100
Open
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Open
fix(frontend): use relative baseURL in production, avoid hardcoded localhost#100JasonOA888 wants to merge 1 commit into666ghj:mainfrom
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Conversation
…calhost Previously baseURL defaulted to 'http://localhost:5001' in all environments, causing issues when deployed on servers or Docker with port mapping. Changes: - Use relative path (empty string) in production for same-origin deployment - Keep localhost:5001 default for development environment - Still respects VITE_API_BASE_URL env var if set Fixes 666ghj#93, related to 666ghj#59, 666ghj#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Frontend
baseURLdefaults tohttp://localhost:5001in all environments, causing:Solution
Make baseURL environment-aware:
localhost:5001defaultVITE_API_BASE_URLstill takes highest priorityTesting
VITE_API_BASE_URLsetFixes #93, related to #59, #57