Fix in SearchBuilder._initialize_additional_facets for array-of-primitive type - #308
Open
dmichaels-harvard wants to merge 2 commits into
Open
Fix in SearchBuilder._initialize_additional_facets for array-of-primitive type#308dmichaels-harvard wants to merge 2 commits into
dmichaels-harvard wants to merge 2 commits into
Conversation
willronchetti
added a commit
that referenced
this pull request
Jul 7, 2026
…nd flaky marks - Fix the CHANGELOG entry heading left as 11.31.1 by the master merge while pyproject.toml said 11.31.7 -- this mismatch was failing both the Static Checks and UNIT CI jobs on the changelog checker. - Add unit tests for the gaps PR #320's own audit listed as deliberate follow-ups: local_roles (principal expansion, role->principal reverse mapping, LocalRolesAuthorizationPolicy), the calculated-property registry (schema default guard, copy+mark, condition/attr dispatch, MRO-ordered props_for, category isolation, ItemNamespace memoization), json_renderer adapters (UUID/set/frozenset/datetime, request-less dumps, BinaryFromJSON, JSONResult.serializer), ManagerLRUCache (no-op outside a request, settings capacity, afterCompletion flush), and the untested EDWHash branches (verify round-trip, bytes/str equivalence, password-too-long boundary). - Re-enable @pytest.mark.flaky(max_runs=3, rerun_filter=delay_rerun) on test_aggregated_items and add it to test_indexer_namespacing and test_indexer_queue_adds_telemetry_id, which use the same SQS/ES polling pattern as their already-protected neighbors (known CI flakiness fix). - Bump version to 11.31.8 (checked open PRs: #321 is at 11.30.8, #308 at 11.24.0 -- no collision) and add a changelog entry. - Record the flaky-mark convention and the ItemNamespace.__getattr__ request=None recursion sharp edge in AGENTS.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
willronchetti
added a commit
that referenced
this pull request
Jul 7, 2026
* Add unit tests closing coverage gaps in pure-logic modules Adds 138 direct unit tests across 8 new files, targeting previously untested (or only indirectly-tested) pure-logic, correctness-sensitive modules. No production code changed; all tests run without ES/Postgres. - test_typedsheets.py: value casting/parsing helpers (cast, parse_*, convert, cast_row_values, remove_nulls) incl. null/empty asymmetry. - test_authorization.py: groupfinder synthetic + user/access-key lookup branches, _create_principals, is_admin_request (security-sensitive). - test_etag.py: ETag/conditional-GET decorators incl. 304 short-circuit and per-principal ETag distinctness. - test_schema_formats.py: is_uuid / is_accession regex validators. - test_server_defaults_misc.py: all add_last_modified branches. - test_predicates.py: SubpathSegments / AdditionalPermission predicates. - test_typeinfo.py: extract_schema_links recursive generator. - test_util_helpers.py: deduplicate_list, ensurelist, gunzip_content, convert_integer_to_comma_string, simple_path_ids, recursively_process_field, resolve_file_path, and merge_calculated_into_properties edge branches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Bump version to 11.30.4 and add changelog entry Patch bump for the test-only coverage additions in the previous commit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Bump version to 11.30.7 per captain merge-order sequence Aligns this PR's version with the captain's merge-order across the open snovault PRs (#317->11.30.4, #321->11.30.5, #318->11.30.6, #320->11.30.7, #319->11.31.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add follow-up coverage tests, fix post-merge changelog mismatch, extend flaky marks - Fix the CHANGELOG entry heading left as 11.31.1 by the master merge while pyproject.toml said 11.31.7 -- this mismatch was failing both the Static Checks and UNIT CI jobs on the changelog checker. - Add unit tests for the gaps PR #320's own audit listed as deliberate follow-ups: local_roles (principal expansion, role->principal reverse mapping, LocalRolesAuthorizationPolicy), the calculated-property registry (schema default guard, copy+mark, condition/attr dispatch, MRO-ordered props_for, category isolation, ItemNamespace memoization), json_renderer adapters (UUID/set/frozenset/datetime, request-less dumps, BinaryFromJSON, JSONResult.serializer), ManagerLRUCache (no-op outside a request, settings capacity, afterCompletion flush), and the untested EDWHash branches (verify round-trip, bytes/str equivalence, password-too-long boundary). - Re-enable @pytest.mark.flaky(max_runs=3, rerun_filter=delay_rerun) on test_aggregated_items and add it to test_indexer_namespacing and test_indexer_queue_adds_telemetry_id, which use the same SQS/ES polling pattern as their already-protected neighbors (known CI flakiness fix). - Bump version to 11.31.8 (checked open PRs: #321 is at 11.30.8, #308 at 11.24.0 -- no collision) and add a changelog entry. - Record the flaky-mark convention and the ItemNamespace.__getattr__ request=None recursion sharp edge in AGENTS.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * version --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up for example in smaht-portal - additional_facet=sample_summary.studies