Skip to content

Bugfix of issue #514 #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschaszott wants to merge 3 commits into
base: main-cris
Choose a base branch
from
Open

Bugfix of issue #514 #515

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74c6c85
bugfix of issue #514
saschaszott Aug 11, 2025
266298d
formatting change: remove trailing whitespace
saschaszott Aug 11, 2025
6981603
added ORDER clause to sort bitstreams of given bundle by bitstream_order
saschaszott Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,15 @@ public Iterator<Bitstream> findByItem(Context context, Item item) throws SQLExce
public Iterator<Bitstream> findShowableByItem(Context context, UUID itemId, String bundleName) throws SQLException {
Query query = createQuery(
context,
"select b.id from Bitstream b " +
"join b.bundles bitBundle " +
"join bitBundle.items item " +
"select bitstream.id from Bundle bundle " +
"join bundle.items item " +
"join bundle.bitstreams bitstream " +
"WHERE item.id = :itemId " +
"and NOT EXISTS( " +
" select 1 from MetadataValue mv " +
" join mv.metadataField mf " +
" join mf.metadataSchema ms " +
" where mv.dSpaceObject = b and " +
" where mv.dSpaceObject = bitstream and " +
" ms.name = 'bitstream' and " +
" mf.element = 'hide' and " +
" mf.qualifier is null and " +
Expand All @@ -169,13 +169,14 @@ public Iterator<Bitstream> findShowableByItem(Context context, UUID itemId, Stri
" from MetadataValue mvB " +
" join mvB.metadataField mfB " +
" join mfB.metadataSchema msB " +
" where mvB.dSpaceObject = bitBundle and " +
" where mvB.dSpaceObject = bundle and " +
" msB.name = 'dc' and " +
" mfB.element = 'title' and " +
" mfB.qualifier is null and " +
" mvB.value = :bundleName " +
" )" +
")"
")" +
" ORDER BY INDEX(bitstream)"
);

query.setParameter("itemId", itemId);
Expand Down