-
Notifications
You must be signed in to change notification settings - Fork 14
Adding the fit_model function
#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
added full formula creator
added fixed effects string generator
1. Put ‘data= simdf_time’ inside the function like( ). 2. Delete ‘marginal = bru_mapper_marginal(qexp, rate = 1)’, ‘group_mapper = bru_mapper(mesh)’, and ‘qexp <- stats::qnorm(p, mean = 0, sd = 1, lower.tail = TRUE, log.p = FALSE)’ simply because they keep reporting errors.
fix constrained model run errors
Iss273/new data sets
XueqingYin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi , I found several issues in fit_model.R and fit_model.Rmd.
for fit_model.R:
- The purpose of having two
inlabru::like()in this model is not clear to me. Maybe it's useful to explain the aim of eachlike(), and the problem that this model is solving? - Do you want to include the arguments (such as max.edge) that control mesh resolution when creating mesh? At present, they are missing in
fm_mesh_2d_inla(), and I foundmax_edge_meshis not used. - The object types for
space_variables,spacetime_variables, anddataneed clear description. Ifspace_variablesandspacetime_variablesarelistobjects as described now at the beginning of the script, thendata[space_variables]will give an error "Error in .subset2(x, i, exact = exact) : invalid subscript type 'list'". To avoid this,space_variablesandspacetime_variablesshould be a vector of spatial and spacetime variables, respectively. - The input for the argument
locationsshould be a matrix of point locations, rather than a list of coordinates
for fit_model.Rmd:
process_coordsargument does not exist in thefit_model()functionspace_variablesandspacetime_variablesare missing in this rain example- If I remember it correctly,
inlabru::brurequires the time index to start from 1, whereas it now starts from 5 in this example
|
For the fit_model.rmd we actually stopped using that and it should be removed because we switched to using the test_fit_model.rmd |
|
Also, |
|
We didn't put the arguments |
This will add a
fit_modelfunction that in one line will createfit_model- generate formula #275fit_model- meshing function #274fit_model- fitting the model #276stylerrun over codeCHANGELOG.mdfile if fixing a bug or adding a new featureDESCRIPTION