Remove redundant definition from input file - #2185
Merged
c-p-schmidt merged 1 commit intoAug 14, 2026
Merged
Conversation
tuchpaul
approved these changes
Aug 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant INITFUNCNO setting from an SSI manifold YAML input file where the initial field is configured via field_by_condition (i.e., defined by conditions rather than a function), aligning the input with how manifold initial-field parameters are interpreted in the codebase.
Changes:
- Deleted
INITFUNCNO: 5fromSSI CONTROL/MANIFOLDwhereINITIALFIELD: "field_by_condition"is used.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ischeider
approved these changes
Aug 14, 2026
ischeider
left a comment
ischeider
left a comment
Contributor
There was a problem hiding this comment.
My personal view is rather to make a comment behind INTIFUNCNO that it is not used here, so that one can switch easily to another simulation feature. But I know this is not the 4C policy ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
While working on coating simulations, I realized that there is redundant information in one of our input files. As the input file states, the initial field is defined by condition and not by function. Nevertheless, a function to define this initial field was also defined, which is now removed.
Related Issues and Pull Requests
none
Disclosure of AI assistance
none