Make updating regexps.js more atomic to prevent server crashes#89
Open
dattas wants to merge 1 commit into3rd-Eden:masterfrom
dattas:master
Open
Make updating regexps.js more atomic to prevent server crashes#89dattas wants to merge 1 commit into3rd-Eden:masterfrom dattas:master
dattas wants to merge 1 commit into3rd-Eden:masterfrom
dattas:master
Conversation
Author
|
Looks like the build failed due to npm issues, closing and re-opening to have it try again. |
Author
|
Looks like the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally the auto update fails while writing to the regexps.js file, leaving a blank file and causing node to fail and prevents starting of the application. This change writes the changes to a temporary file first and if there are no issues, then it renames it. This makes the process more atomic and has improved reliability on our servers.