-
Notifications
You must be signed in to change notification settings - Fork 37
Entity color options revisit #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ewei2406
wants to merge
26
commits into
3DStreet:main
Choose a base branch
from
ewei2406:entity-color-options-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you noted in the assets-dist repo, there is a file size impact of vertex colored models; the file size itself is probably ok as the objects can easily be cached. I also tested this out with complicated scenes and it seems to work ok, for example https://dev-3dstreet.web.app/#/scenes/848d4f7f-d04b-491c-b531-216ed8b9b593 Checklist before merging, this is still a wip
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Entity Color Options, integrated with new vertex color assets from 3DStreet/3dstreet-assets-dist#45. To test locally, use the new assets branch to serve the assets. This can be done easily by setting
assetBasePath
insrc/assets.js:4
tohttp://localhost:8000
or wherever it is being served locally.For more information on Vertex Colors see the tutorial added to the assets repo: https://github.com/3DStreet/3dstreet-assets-dist/blob/e679cb898d842df8e7f82eb96a86e0fdeea9baf7/docs/VertexColors.md
The component

custom-colors
is used to modify vertex groups' colors. Modifying the colors is done with the new Custom Colors widget, which uses the native OS color picker (shown below is on MacOS). Custom color data is serialized as CSS pairs -Accent: #ffffff;Paint: #ff0000
etc.All entities can have their color modified, though ones without vertex groups will only receive a tint effect. The names of the materials is pulled directly out of the model itself.

Managed streets have the ability to apply custom colors to all their descendants that have a material named "Accent". Two options are available: random colors, or neutral auto colors.
