Repository navigation
fix(speedtest): test custom JSON profiles concurrently - #6457
Open
XuliGan4eg2006 wants to merge 1 commit into
Open
XuliGan4eg2006 wants to merge 1 commit into
XuliGan4eg2006 wants to merge 1 commit into
Conversation
Custom profiles (full Xray JSON, e.g. Remnawave-style JSON subscriptions) were sent to the delay probe untrimmed and serialized behind a global mutex, so a JSON subscription was tested one profile at a time and each unreachable server cost up to two 12 s attempts before the next started. - Reduce custom configs to log + outbounds (mux removed) before probing, matching what the native probe keeps and postProcessForSpeedtest does for generated profiles. This also stops injecting a TUN inbound into probe configs. - Keep global serialization only for custom configs containing a WireGuard outbound, the case that reproduced the native panic in 2dust#6077. Other custom profiles use the configured real-ping concurrency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On subscriptions served as Xray JSON (e.g. Remnawave), "Test real delay"
is much slower than on the same subscription as share links. Each entry is stored as a
custom profile, and custom profiles were probed one at a time (global mutex from #6083),
untrimmed, and without the fast TCP pre-check. Each dead server could block the queue
for ~24 s.
Changes
log+outbounds(no mux) before probing, the sametrimming generated profiles get. The native probe keeps only these parts anyway, so
results don't change.
[Bug]: App stops during real-latency testing of WireGuard configs. #6077). All other custom profiles use the normal real-ping concurrency.
Result
On my subscription (79 custom profiles), the real-delay test went from ~10 min to ~1 min.
Testing
testPlaystoreDebugUnitTestandassemblePlaystoreDebugpassed on GitHub Actions.