Repository navigation
TV UI, part 5: Custom config and custom outbound editors - #6454
Open
eliotcougar wants to merge 2 commits into
Open
eliotcougar wants to merge 2 commits into
eliotcougar wants to merge 2 commits into
Conversation
Share the existing JSON editor and profile operations. On TV, separate document navigation from keyboard entry so Back can dismiss the IME without taking focus away from the cursor. Reuse the shared focus, field, and IME inset controls without changing their implementations.
Keep the text target focused without starting the IME until Center is pressed. Preserve a pending delete confirmation through the same configuration change.
eliotcougar
marked this pull request as ready for review
November 14, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Custom config (a full JSON configuration) and Custom outbound (one JSON outbound) already open the same editor. This slice makes that editor usable with a TV remote, without changing either profile format or duplicating the JSON editor. Import, validation, parsing, and save/delete operations still use the existing paths.
What changes on TV
Phones retain the existing touch layout, JSON editor, and text-input behavior. Retaining the delete confirmation across recreation is shared. The separate phone bug where a visible keyboard loses its text target is addressed in #6453, not here.
Overlap and review order
ServerCustomConfigActivity.ktwires the TV focus and keyboard policy into the existing editor. Line numbers, text state, scrollbars, and profile operations remain shared.TvJsonFocus.kthandles the JSON editor's three interaction states: screen navigation, cursor movement with the keyboard closed, and text entry with the keyboard open. The second commit handles activity recreation.FormFields.kt,OutboundEditorFocus.kt, andTvEditorFields.ktare byte-for-byte identical to the versions in slice 3 (TV UI, part 3: Standard outbound profile editors #6452, standard outbound forms) and slice 4 (TV UI, part 4: Policy group and proxy chain editors #6451, policy groups and proxy chains). Slice 5 includes them so it can be reviewed and built directly againstmaster. A local merge simulation at the published tips found no conflicts with either slice.Validation
Not run: Spoken TalkBack, physical-device checks, or a full RTL/dynamic-color matrix.