Skip to content

TalkBack, 10 of 10: Announce connection test feedback - #6168

Open
eliotcougar wants to merge 15 commits into
2dust:masterfrom
eliotcougar:fix/accessibility-connection-tests
Open

eliotcougar wants to merge 15 commits into
2dust:masterfrom
eliotcougar:fix/accessibility-connection-tests

Conversation

@eliotcougar

@eliotcougar eliotcougar commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Separate connection-test announcements from continuously changing visual status in part 10 of the TalkBack series.

  • Keep the bottom row's accessible connection state stable. Expose its native localized Check connectivity action only while connected; current and bulk progress remain visible without becoming TalkBack status updates.
  • Queue Testing before the terminal current-test result or bulk completion in an assertive live region. A fast result waits for start publication, and repeated identical results keep distinct event IDs.
  • Make a completed current-test result available on the status row after its transient publication retires, including localized delay units, failure details, and available country/IP information.
  • Collect transient announcements only while the screen is resumed. Leaving clears pending speech; durable results remain in ViewModel state for later navigation.

The live-region helper is byte-identical to Parts 1 and 9. It retains locale spans, a stable hidden idle node, frame-separated publication, and publication acknowledgement. Each update is held briefly after acknowledgement; this does not claim to detect when TalkBack finishes speaking. No direct speech announcements, focus requests, native-role suppression, or interactive Snackbar/Toast nodes are added.

Upstream's independent current/bulk request IDs remain authoritative: stale completion and cancellation replies cannot retire newer requests. Cancellation does not announce successful completion. No native API or persisted format changes are introduced by this PR.

Synced by merging upstream 2.3.15 (57907cf354) without rewriting history. Review preserved the upstream DNS/WireGuard/Hysteria/native changes and subscription infinity/RTL rendering. Shared bottom-bar and ViewModel merge simulations with Parts 1, 8, and 9 are conflict-free and order-independent; Part 8's service action label survives alongside test-status suppression.

Validation at df5a48c68:

  • Focused announcement-order, repeated-result, cancellation, stale-publication, and request-ownership tests: 7 passed.
  • Full Play Store and F-Droid JVM suites: 127 and 127 passed, respectively; no failures, errors, or skips.
  • Both debug Kotlin compilations, ARM64 APK assemblies, and full lint tasks passed with zero lint errors.
  • Ten resource catalogs passed XML, duplicate-key, placeholder, and upstream-preservation checks, covering 30 localized feature entries. git diff --check passed.
  • Native inputs match upstream AndroidLibXrayLite v26.10.31 and HEV 2.19.3. All four input ABIs were checked; the validation APKs contain all three required ARM64 native libraries.

Not run: device/emulator TalkBack, semantics-tree/event inspection, speech timing, actual blocking JNI cancellation or VPN/proxy/root stop/reload races, background/recreation flows, or the complete input/theme/locale/layout matrix on this synced revision. No ADB target is available and an existing QEMU process has unresolved ownership. Build and JVM checks do not establish runtime accessibility behavior.

Keep bottom-bar accessibility semantics tied to the stable connection state while visual test progress continues to update. Emit assertive, locale-aware announcements only for test start and terminal current or bulk results, with localized spoken delay units and the native connection-test action intact.
@eliotcougar eliotcougar changed the title TalkBack, 10 of N: Announce connection test feedback TalkBack, 10 of 10: Announce connection test feedback Aug 30, 2026
Use millisekundu after the connection succeeded in phrase for one millisecond and other counts ending in one. The connection-test plural is already separate from standalone server-row delay units, whose nominative remains unchanged.

Play Store debug resource compilation and APK assembly pass. This changes no connection-test progress or result lifetime behavior.
@aliRahimi1997

Copy link
Copy Markdown
Contributor

I tested this PR with TalkBack.

The connection-test result itself is announced correctly when the test finishes, and there is no problem with that announcement.

The issue is that the result does not remain available on the “Check status” button after the test completes.

For example, if the test reports “Connected” and I hear it at that moment, everything is fine. However, if I do not hear the announcement, there is no result left on the button for TalkBack to read later. I have to run the connection test again to get the result announced again.

So the problem is not that the button cannot read its status when it has one. The problem is that the test result is not retained as persistent accessible information on the button after the test finishes.

Could you please check whether the latest connection-test result can remain exposed through the appropriate accessibility semantics/content of the button after the test completes, while keeping the existing one-time announcement?

I did not observe any other issue with the connection-test announcement.

@eliotcougar

Copy link
Copy Markdown
Contributor Author

The testing progress and result was hidden from TalkBack to prevent duplicate announcements (from the status bar and the live region at the same time). I guess, we can reset the hidden state after it was spoken once.

@eliotcougar
eliotcougar marked this pull request as draft August 31, 2026 09:25
Expose the localized current-test result as merged row text after its short-lived assertive live-region node retires. Keep the connection label stable and hide result text during another test, bulk progress, or disconnection. Reuse the full delay formatter and app-locale spans without changing visual text or native actions.

Cover success and error results, repeated event IDs, and retained state in JVM tests. Add an Android accessibility-tree regression for live-region visibility, repeated results, and the native connection-check action.
@eliotcougar
eliotcougar marked this pull request as ready for review August 31, 2026 12:31
aliRahimi1997 added a commit to aliRahimi1997/v2rayNG that referenced this pull request Aug 31, 2026
Adopt the overlapping terminology corrections from PR 2dust#6169 and carry them into branch-only plural and accessibility resources. This keeps later merge resolution from restoring stale Bakhtiari wording.
Keep feature-specific additions away from the common translated lines changed by neighboring accessibility PRs. Preserve every resource name, value and placeholder in the existing catalog.
Reuse Part 1's live-region primitive and queue start/result publication only while the screen is resumed. Keep terminal results readable after transient feedback retires, without direct announcements or focus changes.

Correlate current and bulk IPC replies by request ID, distinguish notification cancellation from completion, and acknowledge absent or cancelled native tests. Own native probe cancellation across replacement, stop, and reload so late replies cannot become fresh feedback.

Replace the permanent Android fixture and copy-only helper tests with focused request/queue regressions. Validation: 64 JVM tests, Play Store debug compilation/assembly, TalkBack-preserving external emulator checks, and 20 clean pairwise merge simulations. Actual JNI stop/reload races across all service modes were not run.
Build announcements on upstream request identities, acknowledged delivery, worker cancellation, and batched result flushing. Publish only accepted starts and final results; keep progress inert and retain the completed result for later status-row navigation. Remove duplicated lifecycle code and request-policy tests already merged upstream, without changing the service protocol.
@eliotcougar
eliotcougar marked this pull request as ready for review September 21, 2026 11:33
Preserve the upstream start-button rotation while retaining ordered assertive test announcements, inert progress and the last result after announcement. Keep current request-ID cancellation behavior and migrate the feedback regression tests to JUnit Platform.

Validation: 101 JVM tests, Kotlin compilation and PlaystoreDebug assembly passed. API 37 emulator probe with TalkBack enabled checked same-frame start/result order, retained results, stale replies, cancellation, paused delivery and bulk-progress suppression. Real-network probes and physical-device validation were not run.
Preserve the current upstream main-screen group bar, subscription-info overlay, response-header parsing and dependency/native updates. Retain assertive start/result live regions, inert changing test progress, request correlation and the settled status result. Keep the shared live-region helper aligned with part 1.

Add connection-test completion, connected-state and plural delay wording for the newly supported Azerbaijani locale. Validation: full Play Store JVM tests, Kotlin compilation and x86_64 debug assembly pass. Device test coverage is recorded separately; no runtime conclusion is inferred from assembly.
Place this feature's translated resources near their owning screens and align shared action resources across the TalkBack set. Every resource entry, value, attribute, placeholder and plural item is unchanged; catalogs remain in the existing strings.xml files. This avoids same-location insert conflicts, including the newly supported Azerbaijani locale and Bakhtiari catalog.

Exact-entry XML preservation, duplicate-key and whitespace checks pass. Full JVM/Kotlin/APK checks passed before this content-neutral catalog relocation; the final committed-tree build checks follow separately.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Oct 22, 2026
…on-tests

Integrate the verified current PR tip f4f0445 onto upstream 01b4630. Keep the focused branch unchanged and the integration local-only.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Nov 2, 2026
Integrate the published fix/accessibility-connection-tests head df5a48c after its upstream compatibility review. Preserve the focused PR history and its latest fixes.
Preserve the redesigned track and its connection test action. Track intermediate and terminal replies by request ID so a stale reply cannot replace a newer test. Announce only the final reply, even when the IP lookup returns no information.
Keep endpoint lookup independent of result publication so the Xray TUN lookup change merges without changing the accessibility protocol.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants