Skip to content

TalkBack, 3 of 10: Improve asset file accessibility - #6159

Open
eliotcougar wants to merge 12 commits into
2dust:masterfrom
eliotcougar:fix/accessibility-asset-rows
Open

eliotcougar wants to merge 12 commits into
2dust:masterfrom
eliotcougar:fix/accessibility-asset-rows

Conversation

@eliotcougar

@eliotcougar eliotcougar commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Part 3 of the focused TalkBack series makes each asset one informational accessibility group containing its name, localized file size, and update date/time, or the existing missing-file message. Edit and Delete are ordered custom actions; Edit is omitted for locked and file-imported assets. The row has no activation action, and visible buttons retain touch and keyboard input with duplicate accessibility semantics cleared.

The source editor's Delete action and confirmation identify the saved asset even while its name is being edited. List deletion stores a saveable asset ID and resolves the current item from the latest list. Existing deterministic built-in IDs and persisted GUIDs remain intact. File-size/date formatting uses the configured locale and 12/24-hour preference; the editor retains its scrollable, IME-aware form.

Synced with v2.3.15 (57907cf354d9) using a merge commit. Review found no new code fix needed: the separate subscription info box, metadata pipeline, DNS/WireGuard/Hysteria changes, OkHttp 5.5.1, workflow configuration, and native pins are preserved. The default and nine maintained locale catalogs retain all feature entries and matching placeholders. No accessibility instrumentation directory is introduced.

Validation on 3a09f3679:

  • Both focused asset-identity tests passed. The full Play Store suite passed 124 tests with zero failures, errors, or skips.
  • Play Store Kotlin compilation, debug APK assembly, and full lint passed; lint reported zero errors.
  • The matching official v26.10.31 AAR and HEV 2.19.3 inputs were verified for all four ABIs. The assembled ARM64 APK contains the exact expected Go JNI and two HEV libraries.
  • All ten catalogs passed preservation, duplicate-key, translation-presence, and placeholder checks. git diff --check passed.

F-Droid validation was not repeated: this feature changes no flavor-dependent code, resources, dependencies, or shared feedback helper.

Not run: current-head TalkBack custom-action invocation and spoken labels/focus order, touch/keyboard/D-pad input, locale/clock output, saved deletion/editor state after recreation, or the theme/IME/inset matrix. No ADB target is available; emulator ownership is unresolved and no emulator was launched. No new native-speaker translation review was performed.

Asset downloads, storage operations, notification policy, and the adjacent asset-save validation-order fix in #6190 remain outside this PR.

@eliotcougar eliotcougar changed the title TalkBack, 3 of N: Improve asset file accessibility TalkBack, 3 of 10: Improve asset file accessibility Aug 30, 2026
@eliotcougar
eliotcougar marked this pull request as ready for review August 30, 2026 17:47
@eliotcougar
eliotcougar marked this pull request as draft August 31, 2026 19:08
@eliotcougar
eliotcougar marked this pull request as ready for review September 2, 2026 00:38
@eliotcougar
eliotcougar marked this pull request as draft September 5, 2026 11:12
eliotcougar and others added 6 commits September 10, 2026 11:07
Group each asset file's informational text into one non-actionable semantics node while retaining native Edit and Delete buttons with contextual labels. Replace only the compact size and timestamp semantics with localized spoken text, and keep the visible row unchanged. Name asset sources in their delete action and confirmation, and make the touched editor form scroll safely above the IME.
Take only acc_add_asset and acc_download_file from Hossein Abaspanah's translation update (39725a4). Leave the broader translation changes in 2dust#6169. Play Store debug resource compilation and APK assembly pass.

Co-authored-by: Hossein Abaspanah <63148255+hosseinabaspanah@users.noreply.github.com>
Remove Edit and Delete from accessibility swipe traversal while preserving direct touch and keyboard behavior. Present the available operations as ordered custom actions on the inert asset row without adding a row activation action.
Adopt the overlapping terminology corrections from PR 2dust#6169 and carry them into branch-only plural and accessibility resources. This keeps later merge resolution from restoring stale Bakhtiari wording.
Keep feature-specific additions away from the common translated lines changed by neighboring accessibility PRs. Preserve every resource name, value and placeholder in the existing catalog.
Use stable filename-derived IDs for built-in rows so reloads no longer replace their accessibility identity. Retain a pending deletion by saveable ID and resolve its current name; preserve editor drafts and confirmation visibility across recreation.

Use the configured app locale and user 12/24-hour preference for minute-only dates, and Android localized file-size formatting consistently for visible and spoken metadata. Simplify missing metadata handling, unused list indices, and descriptions hidden by row-owned custom actions.

Remove the standalone Android-test harness and keep two focused JVM identity regressions. All 59 JVM tests, Kotlin compilation, debug assembly, nine-locale checks, and both-order companion/upstream merge simulations pass. Emulator checks cover localized metadata, native controls and rotation; direct TalkBack actions and speech remain unverified. Asset storage operations and notification behavior are unchanged.
@eliotcougar
eliotcougar force-pushed the fix/accessibility-asset-rows branch from f09e52b to 8d0c3ec Compare September 10, 2026 09:37
Reuse the shared named deletion dialog and remove obsolete named-confirmation resources in every locale. Preserve upstream asset identity, metadata formatting, editor drafts, keyboard handling, and save validation; retain the row custom actions and saveable deletion target without duplicating extracted behavior.
@eliotcougar
eliotcougar marked this pull request as ready for review September 21, 2026 11:28
Resolve shared-resource conflicts without dropping feature-specific semantics or current upstream translations. Retain upstream service and UI updates, and migrate feature regression tests to the upstream JUnit Platform setup.

Validation: PlaystoreDebug JVM suite, Kotlin compilation and APK assembly passed. All declared ABIs contain the current Xray library and both HEV libraries. Full device and OEM lifecycle regression coverage was not run.
Retain stable asset IDs, saved deletion targets, localized file details and custom edit/delete actions with inert descendant buttons. Complete the three feature translations in the maintained Azerbaijani catalog while preserving upstream resource and native changes.

Playstore 113 JVM tests, Kotlin compilation and x86_64 debug assembly passed. All three required native libraries are packaged. Preserve upstream subscription usage/header capture, pill group navigation and Kotlin/Gradle updates. Runtime accessibility, input, persistence and restoration checks were not run because device access is reserved for the parent.
Place this feature's translated resources near their owning screens and align shared action resources across the TalkBack set. Every resource entry, value, attribute, placeholder and plural item is unchanged; catalogs remain in the existing strings.xml files. This avoids same-location insert conflicts, including the newly supported Azerbaijani locale and Bakhtiari catalog.

Exact-entry XML preservation, duplicate-key and whitespace checks pass. Full JVM/Kotlin/APK checks passed before this content-neutral catalog relocation; the final committed-tree build checks follow separately.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Oct 22, 2026
Integrate the verified current PR tip c714443 onto upstream 01b4630. Keep the focused branch unchanged and the integration local-only.
Preserve the focused accessibility behavior while taking the current DNS final-query ordering, WireGuard DNS defaults, Hysteria port handling, subscription figures and RTL updates, and official native dependency revisions. Follow-up validation uses the matching v26.10.31 AAR and HEV 2.19.3 inputs.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Nov 2, 2026
Integrate the published fix/accessibility-asset-rows head 3a09f36 after its upstream compatibility review. Preserve the focused PR history and its latest fixes.
eliotcougar added a commit to eliotcougar/v2rayNG that referenced this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant