fix(provider): prevent heimdall span ID collapse on API errors#71
Merged
fix(provider): prevent heimdall span ID collapse on API errors#71
Conversation
When heimdall-api returns a 5xx with a JSON error envelope, the body was decoding into a zero-value struct (ID=0, StartBlock=0, EndBlock=0), causing panoptichain to treat it as a real span and walk +1 per tick. Changes: - Add HTTP status code validation in api.GetJSON before JSON decoding - Reject zero-value spans in fetchSpan as defense-in-depth - Cap sequential span walking with configurable max_span_lag (default 10) to prevent multi-hour catch-up walks after transient failures
…hecks - exchange_rates: use api.GetJSON instead of direct http.Get for consistent status code validation - grafana provider: add HTTP status check and 10s timeout to prevent silent failures on non-2xx responses - grafana observer: add array bounds validation before accessing frame.Data.Values to prevent panics on malformed responses
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When heimdall-api returns a 5xx with a JSON error envelope, the body was decoding into a zero-value struct (ID=0, StartBlock=0, EndBlock=0), causing panoptichain to treat it as a real span and walk +1 per tick.
Changes:
Jira / Linear Tickets
Testing