chore: Rename NoteMetadata to PartialNoteMetadata#2887
Open
PhilippGackstatter wants to merge 3 commits intopgackst-multiple-note-attachments-followupfrom
Open
chore: Rename NoteMetadata to PartialNoteMetadata#2887PhilippGackstatter wants to merge 3 commits intopgackst-multiple-note-attachments-followupfrom
NoteMetadata to PartialNoteMetadata#2887PhilippGackstatter wants to merge 3 commits intopgackst-multiple-note-attachments-followupfrom
Conversation
PhilippGackstatter
added
the
pr-from-maintainers
PhilippGackstatter
force-pushed
the
pgackst-partial-note-metadata
branch
from
f429506 to
a8daf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
NoteMetadatatoPartialNoteMetadataandNoteMetadataHeadertoNoteMetadataas motivated in #2874 (comment).Small change sneaked in: Simplifies
BatchNoteTreeandBlockNoteTreeconstructors to takeNoteHeaderinstead ofNoteId+NoteMetadata.closes #2874