chore: unify word and array attachment into one#2871
Open
PhilippGackstatter wants to merge 25 commits into
Open
chore: unify word and array attachment into one#2871PhilippGackstatter wants to merge 25 commits into
PhilippGackstatter wants to merge 25 commits into
Conversation
8849c56 to
a441919
Compare
a441919 to
6dd9c49
Compare
This was referenced May 6, 2026
…-multiple-note-attachments-followup
mmagician
approved these changes
May 7, 2026
mmagician
reviewed
May 7, 2026
…-multiple-note-attachments-followup
bobbinth
reviewed
May 10, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a few small comments inline. Not approving yet as things may change a little depending on what we do in the base PR.
…-multiple-note-attachments-followup
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses various follow-up issues from the previous attachment PRs:
NoteAttachmentContent.NoteAttachmentrenamenew_word->with_word&new_array->with_words.add_array_attachmenttoadd_words_attachmentwhich takes a ptr and num words as input.NoteHeaderandNoteMetadataCopy(as it was before note attachments were added to metadata).constants.masmforWORD_NUM_ELEMENTS(named as per the upcoming refactor(Word): MakeWordconstants consistent crypto#917).note.md.metadata_into_tagand use it in PSWAP code. See issue TODO for the motivation behind this procedure.closes #2555